[Bug 59162] fix post-0.18 deprecations (and test/fix broken-by-inspection service point code in the process).

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=59162

--- Comment #11 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Review of wjt's WiP:

> -AC_DEFINE([TP_VERSION_MIN_REQUIRED], [TP_VERSION_0_18],
> - [Ignore post-0.18 deprecations])
> +AC_DEFINE([TP_VERSION_MIN_REQUIRED], [TP_VERSION_0_20],
> + [Ignore post-0.20 deprecations])

This is obviously fine as soon as it actually compiles :-)

Also please define TP_SEAL_ENABLE and TP_DISABLE_SINGLE_INCLUDE, if/when they
work (make distcheck is the safest way to test this stuff).

If you like this sort of thing, I recently did similar updates on Salut, Bug
#54119.

> +service_handles_fetched_cb (

This is the work that is in progress, I assume? My patches here should
hopefully fix this.

> - self_handle = tp_connection_get_self_handle (proxy);
> + self_handle = tp_contact_get_handle (tp_connection_get_self_contact (proxy));

As I mentioned on Bug #55391, I would rather make MC use higher-level APIs for
presence (like I did for Aliasing and Avatars on Bug #55668). I'd be OK with
doing this quick change for now to avoid the deprecations, and splitting out
"use TP_CONTACT_FEATURE_PRESENCE" into a separate bug, if you'd prefer.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.