[Bug 27727] account storage plugins can contain partial accounts

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27727

--- Comment #45 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Missing things are:

> If we have an untyped param, now is a good time to move to to sa->parameters
> and consider that to be a change.

It breaks a regression test, which is trying to assert that if you have an
account in a low-priority location, just starting MC isn't enough to get it
copied into a higher-priority location. The same test verifies that
keyfile-escaped parameters (UntypedParameters) are unescaped correctly.

For that test to check what it's meant to check, I need to split it into "the
one that is in a low-priority location" and "the one that has old-style
parameters".

and...

> sa = lookup_stored_account (amd, account);
> g_return_val_if_fail (sa != NULL, MCP_ACCOUNT_STORAGE_SET_RESULT_FAILED);
> 
> if (val == NULL)
>   {
>     ...
>   }
> else
>   {
>     ...
>   }

Which plugin is this? If it's McdAccountManagerDefault, I think I might have
actually fixed that while fixing your other review feedback.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.