[Bug 27727] account storage plugins can contain partial accounts

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27727

--- Comment #46 from Xavier Claessens <xclaesse at gmail.com> ---
(In reply to comment #45)
> > sa = lookup_stored_account (amd, account);
> > g_return_val_if_fail (sa != NULL, MCP_ACCOUNT_STORAGE_SET_RESULT_FAILED);
> > 
> > if (val == NULL)
> >   {
> >     ...
> >   }
> > else
> >   {
> >     ...
> >   }
> 
> Which plugin is this? If it's McdAccountManagerDefault, I think I might have
> actually fixed that while fixing your other review feedback.

You fixed it already ;-)

0e7da13f3d4a1607372420fedca1124046b8716c _mcd_account_manager_setup:
Nitpicking: you iterate on hash table values, but the key is already the
unique_name, no? so you could just take the key instead of calling
mcd_account_get_unique_name().

The rest looks good to me.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.