[Bug 31757] implement Proto.I.Avatars in Haze

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Sep 18 02:53:41 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=31757

--- Comment #11 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 86042
  --> https://bugs.freedesktop.org/attachment.cgi?id=86042
avatars: factor out haze_connection_get_icon_spec_requirements()

Review of attachment 86042:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=31757&attachment=86042)
-----------------------------------------------------------------

OK with a trivial change:

::: src/connection-avatars.c
@@ +170,5 @@
> +    guint *max_width,
> +    guint *max_bytes)
> +{
> +    if (mime_types != NULL)
> +      *mime_types = dup_mime_types (icon_spec);

Indent 2 more spaces, if that's the indentation convention you're using (or
indenting this function in Telepathy style would also be OK, IMO). No need to
ask for re-review for that.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the telepathy-bugs mailing list