[Bug 31757] implement Proto.I.Avatars in Haze

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31757

--- Comment #12 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 86043
  --> https://bugs.freedesktop.org/attachment.cgi?id=86043
protocol: implement get_avatar_details()

Review of attachment 86043:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=31757&attachment=86043)
-----------------------------------------------------------------

::: src/protocol.c
@@ +1003,5 @@
> +  PurpleBuddyIconSpec *icon_spec;
> +
> +  icon_spec = &(self->priv->prpl_info->icon_spec);
> +
> +  if (icon_spec == NULL || icon_spec->format == NULL)

icon_spec will never be NULL: it's the address of something?

::: tests/twisted/cm/protocols.py
@@ +173,5 @@
> +            assertEquals(32, protocol_avatar_props['MinimumAvatarHeight'])
> +            assertEquals(32, protocol_avatar_props['MinimumAvatarWidth'])
> +            assertEquals(0, protocol_avatar_props['RecommendedAvatarHeight'])
> +            assertEquals(0, protocol_avatar_props['RecommendedAvatarWidth'])
> +            assertEquals(['image/png'], protocol_avatar_props['SupportedAvatarMIMETypes'])

assertContains would be more future-proof?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.