[Bug 75450] Missing TpAccountChannelRequest high level API

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Feb 25 10:54:17 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=75450

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
> + tp_asv_set_uint32 (self->priv->request,
> + g_strdup (TP_PROP_CHANNEL_TARGET_HANDLE_TYPE), TP_HANDLE_TYPE_NONE);

I'd rather use g_hash_table_insert instead of tp_asv_set_uint32 in situations
where the memory allocation model doesn't match the one tp_asv_set_uint32
documents (namely "static keys, copied values"). This use of g_strdup() feels
uncomfortably like "compensating errors".

Looks good otherwise.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list