[Bug 75450] Missing TpAccountChannelRequest high level API

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Feb 26 01:31:45 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=75450

Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #3)
> > + tp_asv_set_uint32 (self->priv->request,
> > + g_strdup (TP_PROP_CHANNEL_TARGET_HANDLE_TYPE), TP_HANDLE_TYPE_NONE);
> 
> I'd rather use g_hash_table_insert instead of tp_asv_set_uint32 in
> situations where the memory allocation model doesn't match the one
> tp_asv_set_uint32 documents (namely "static keys, copied values"). This use
> of g_strdup() feels uncomfortably like "compensating errors".

Fixed & merged to master.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list