[Bug 55109] GVariant-based factory instantiation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55109

--- Comment #8 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 94875
  --> https://bugs.freedesktop.org/attachment.cgi?id=94875
logger tests: use a GVariant as params

Review of attachment 94875:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=55109&attachment=94875)
-----------------------------------------------------------------

I've only commented on the Pidgin test, but the log walker has the same issue.

::: tests/logger/dbus/test-tpl-log-iter-pidgin.c
@@ +830,2 @@
>    g_test_add ("/log-iter-xml/get-events",
> +      PidginTestCaseFixture, create_params (),

This is floating, and is consumed by setup(). That's weird.

Either sink it and explicitly unref it after g_test_run() like the old code did
with the GHashTable, or have the user_data be a static or constant string
containing the GVariant string serialization, and parse it in setup().

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.