[Bug 55109] GVariant-based factory instantiation

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Feb 28 04:58:13 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=55109

--- Comment #9 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 94876
  --> https://bugs.freedesktop.org/attachment.cgi?id=94876
client-factory: take a vardict for new connection props

Review of attachment 94876:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=55109&attachment=94876)
-----------------------------------------------------------------

::: telepathy-glib/client-factory.c
@@ +623,4 @@
>  
> +  if (immutable_properties != NULL)
> +    {
> +      g_variant_ref_sink (immutable_properties);

As with the account, sink this before calling the vfunc, so the vfunc doesn't
have to care.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list