[Bug 55109] GVariant-based factory instantiation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55109

--- Comment #13 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 94879
  --> https://bugs.freedesktop.org/attachment.cgi?id=94879
client-factory: take a vardict for new channel props

Review of attachment 94879:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=55109&attachment=94879)
-----------------------------------------------------------------

::: telepathy-glib/base-client.c
@@ +1542,4 @@
>    _tp_connection_set_account (*connection, *account);
>  
>    *channel = tp_client_factory_ensure_channel (self->priv->factory,
> +      *connection, chan_path, tp_asv_to_vardict (chan_props), error);

Non-floating, leaked

::: telepathy-glib/channel-dispatch-operation.c
@@ +277,5 @@
>      return;
>  
>    self->priv->channel = tp_client_factory_ensure_channel (
> +      tp_proxy_get_factory (self), self->priv->connection, path,
> +      tp_asv_to_vardict (properties), &error);

Non-floating, leaked

::: telepathy-glib/channel-request.c
@@ +222,4 @@
>      }
>  
>    channel = tp_client_factory_ensure_channel (tp_proxy_get_factory (self),
> +      connection, chan_path, tp_asv_to_vardict (chan_props), &error);

Non-floating, leaked

::: telepathy-glib/client-factory.c
@@ +776,4 @@
>  
> +  if (immutable_properties != NULL)
> +    {
> +      g_variant_ref_sink (immutable_properties);

Sink before calling the vfunc

::: tests/dbus/call-channel.c
@@ +154,4 @@
>    g_assert_no_error ((GError *) error);
>  
>    test->chan = tp_client_factory_ensure_channel (test->factory,
> +      connection, object_path, tp_asv_to_vardict (immutable_properties),

leaked

@@ +874,4 @@
>    g_assert (test->chan == NULL);
>  
>    test->chan = tp_client_factory_ensure_channel (test->factory,
> +      conn, object_path, tp_asv_to_vardict (properties), &error);

leaked

::: tests/dbus/dbus-tube.c
@@ +139,4 @@
>  
>    factory = tp_proxy_get_factory (test->connection);
>    test->tube = (TpDBusTubeChannel *) tp_client_factory_ensure_channel (
> +      factory, test->connection, chan_path, tp_asv_to_vardict (props),

leaked

::: tests/dbus/file-transfer-channel.c
@@ +216,4 @@
>  
>    factory = tp_proxy_get_factory (test->connection);
>    test->channel = TP_FILE_TRANSFER_CHANNEL (tp_client_factory_ensure_channel (
> +      factory, test->connection, chan_path, tp_asv_to_vardict (props),

leaked

::: tests/dbus/stream-tube.c
@@ +208,4 @@
>  
>    factory = tp_proxy_get_factory (test->connection);
>    test->tube = TP_STREAM_TUBE_CHANNEL (tp_client_factory_ensure_channel (
> +      factory, test->connection, chan_path, tp_asv_to_vardict (props),

leaked

::: tests/dbus/text-channel.c
@@ +83,4 @@
>  
>    factory = tp_proxy_get_factory (test->connection);
>    test->channel = TP_TEXT_CHANNEL (tp_client_factory_ensure_channel (factory,
> +      test->connection, chan_path, tp_asv_to_vardict (props), &test->error));

leaked

@@ +107,4 @@
>        NULL);
>  
>    test->sms_channel = TP_TEXT_CHANNEL (tp_client_factory_ensure_channel (
> +      factory, test->connection, chan_path, tp_asv_to_vardict (props),

leaked

::: tests/lib/util.c
@@ +678,4 @@
>  
>    factory = tp_proxy_get_factory (conn);
>    return tp_client_factory_ensure_channel (factory, conn,
> +      object_path, tp_asv_to_vardict (immutable_properties), error);

leaked

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.