[Bug 55107] GVariant-based Handler_Info

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Feb 28 05:05:54 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=55107

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 94880
  --> https://bugs.freedesktop.org/attachment.cgi?id=94880
handle-channel-context: replace get_handler_info by a GVariant version

Review of attachment 94880:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=55107&attachment=94880)
-----------------------------------------------------------------

::: telepathy-glib/handle-channel-context.c
@@ +690,3 @@
>  {
>    g_return_val_if_fail (TP_IS_HANDLE_CHANNELS_CONTEXT (self), NULL);
> +  return tp_asv_to_vardict (self->handler_info);

Contrary to Bug #55109, this relies for its correctness on tp_asv_to_vardict
*not* returning a floating ref. Pick one :-)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list