[Bug 75581] [next] remove tp_message_peek()

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=75581

--- Comment #10 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 94838
  --> https://bugs.freedesktop.org/attachment.cgi?id=94838
use tp_message_dup_part() instead of tp_message_peek()

Review of attachment 94838:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=75581&attachment=94838)
-----------------------------------------------------------------

::: telepathy-glib/cm-message.c
@@ +307,4 @@
>    g_return_val_if_fail (TP_IS_CM_MESSAGE (self), 0);
> +
> +  header = tp_message_dup_part (self, 0);
> +  g_variant_lookup (header, "message-sender", "u", &sender);

Either

if (!g_variant_lookup (...))
  sender = 0;

or pre-initialize it. Otherwise we'll return undefined stack contents if there
is a message-sender but its type is wrong.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.