[Bug 75581] [next] remove tp_message_peek()
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Fri Feb 28 08:28:10 PST 2014
https://bugs.freedesktop.org/show_bug.cgi?id=75581
--- Comment #11 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 94839
--> https://bugs.freedesktop.org/attachment.cgi?id=94839
message: change string getter to _dup_
Review of attachment 94839:
--> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=75581&attachment=94839)
-----------------------------------------------------------------
::: telepathy-logger/text-channel.c
@@ +259,5 @@
> tpl_entity_get_identifier (sender));
>
>
> + token = tp_message_dup_token (message);
> + supersedes = tp_message_dup_supersedes (message);
Inline get_message_edit_timestamp here, maybe? (Non-blocker)
@@ +277,5 @@
> "message-type", type,
> "message", text,
> NULL);
>
> + g_free (token);
Is supersedes leaked?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the telepathy-bugs
mailing list