[Bug 27727] account storage plugins can contain partial accounts

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27727

--- Comment #50 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #49)
> > For that test to check what it's meant to check, I need to split it into
> > "the one that is in a low-priority location" and "the one that has old-style
> > parameters".

Some progress on chopping up the tests:

http://cgit.freedesktop.org/~smcv/telepathy-mission-control/log/?h=account-rework-27727-round4

(rebased, commits since yours are new)

I haven't implemented automatic migration from untyped to typed parameters yet;
that's next.

I also have a sketch of an Empathy GOA plugin that should be compilable against
either 5.16 or "5.18" (this), although I haven't actually tried compiling it
yet, much less using it!

> > Nitpicking: you iterate on hash table values, but the key is already the
> > unique_name, no? so you could just take the key instead of calling
> > mcd_account_get_unique_name().

Done,
http://cgit.freedesktop.org/~smcv/telepathy-mission-control/commit/?h=account-rework-27727-round4&id=4690efe7ecc874b1149f79118b4e9aa735d71b4e

> (In reply to comment #47)
> > a231756bd832064d531195656df1110c63575717, commit msg says: "We should never
> > have get_something(), commit() with a non-NULL account"
> > s/non-// or s/never/always/ if I understand correctly, right?

Rewrote the commit message to be clearer, I hope it's OK now?

http://cgit.freedesktop.org/~smcv/telepathy-mission-control/commit/?h=account-rework-27727-round4&id=a240b95d030be02c9df1be3d7eb678e966ea60ac

-- 
You are receiving this mail because:
You are the QA Contact for the bug.