[Bug 69430] Make NewChannels, etc., singular?

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69430

--- Comment #52 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #45)
> * Turn TpBaseConnection's ChannelRequest into TpChannelManagerRequest
> 
> * Make it refcounted, or maybe even make it into a trivial GObject
>   (there's no reason why a channel manager should need to ref it,
>   but introspected code will do it anyway)
> 
> * TpChannelManagerRequestFunc's 2nd argument becomes a
> TpChannelManagerRequest*
> 
> * tp_channel_manager_create_channel, ..._ensure_channel,
>   _request_already_satisfied, _emit_request_failed[_printf], and the
>   corresponding vfuncs should take that type too
> 
> * tp_channel_manager_request_channel (and its vfunc) should be removed
>   altogether
> 
> * Write some silly Python that subclasses TpChannelManager and
>   TpExportableChannel (you might need to temporarily remove
>   "TpExportableChannel requires TpSvcChannel")
> 
> * Verify that the chosen type for ::new-channel can work

I implemented exactly this in
http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=next-spec-sync

The ugly python code to test is in
http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=test-gir but
it's not mergeable atm.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.