[Bug 69430] Make NewChannels, etc., singular?

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69430

--- Comment #53 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
This looks great!

> - g_type_interface_add_prerequisite (type, TP_TYPE_SVC_CHANNEL);

Yeah, I was worried you might have to do that in order to test it with GIR. I
don't think not merging this test is a problem.

> +#include "channel-manager-request-internal.h"

Missing from 7dd315. It doesn't really matter a great deal, since the next
patch adds it anyway.

> + /*<private>*/
> + GObject parent;
> +
> + DBusGMethodInvocation *context;
> + TpChannelManagerRequestMethod method;

If the struct ever has to become public, I'd prefer this stuff to be in priv...
talking of which, there's no priv pointer. No need to fix that right now
though.

> + unsigned yours : 1;

I think we use gboolean (and avoid bitfield syntax) fairly consistently, since
bitfields are a bit of a trap (they fail if signed, and gboolean is signed).

> + g_return_val_if_fail (method < NUM_TP_CHANNEL_MANAGER_REQUEST_METHOD, NULL);

TP_NUM_..._METHODS

> + //GParamSpec *spec;

Please delete any remaining commented-out code at the end of the branch, and
use /* */ for anything intentionally left in.

Please remove get_property, set_property, constructed, dispose unless you're
going to use them later in the branch.

> +void
> +_tp_channel_manager_request_cancel (TpChannelManagerRequest *self)

Now that we have a little less control over its lifetime, please
g_return_if_fail (self->context != NULL)

> +void
> +_tp_channel_manager_request_satisfy (TpChannelManagerRequest *self,
> + TpExportableChannel *channel)

Here, too

> +void
> +_tp_channel_manager_request_fail (TpChannelManagerRequest *self,
> + GError *error)

And here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.