[Bug 68892] tp_list_connection_managers_async does not invoke the callback if there are no CMs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=68892

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 95949
  --> https://bugs.freedesktop.org/attachment.cgi?id=95949
tp_list_connection_managers_async: terminate properly if there is no CM

Review of attachment 95949:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=68892&attachment=95949)
-----------------------------------------------------------------

Both patches look fine, apart from a minor bug in the regression test.

::: tests/dbus/list-cm-no-cm.c
@@ +66,5 @@
> +  GError *error = NULL;
> +
> +  /* This test relies on D-Bus not finding any service file so tweak
> +   * TP_TESTS_SERVICES_DIR to point to an empty directory. */
> +  dir = g_dir_make_tmp ("tp-glib-tests.XXXXXX", &error);

At the end, please save the result of tp_tests_run_with_bus(), g_rmdir() this
directory, *then* exit with the saved result.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.