[Bug 68892] tp_list_connection_managers_async does not invoke the callback if there are no CMs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=68892

Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #4)
> Comment on attachment 95949 [details] [review]
> tp_list_connection_managers_async: terminate properly if there is no CM
> 
> Review of attachment 95949 [details] [review]:
> -----------------------------------------------------------------
> 
> Both patches look fine, apart from a minor bug in the regression test.
> 
> ::: tests/dbus/list-cm-no-cm.c
> @@ +66,5 @@
> > +  GError *error = NULL;
> > +
> > +  /* This test relies on D-Bus not finding any service file so tweak
> > +   * TP_TESTS_SERVICES_DIR to point to an empty directory. */
> > +  dir = g_dir_make_tmp ("tp-glib-tests.XXXXXX", &error);
> 
> At the end, please save the result of tp_tests_run_with_bus(), g_rmdir()
> this directory, *then* exit with the saved result.

I've done that and merged the branch.

Fixed for 0.23.3.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.