[Bug 76369] [next] Remove dbus-glib GTypes from public API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=76369

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
I've reviewed header files, but not signals or properties yet (I glanced at
them where functions are implemented in terms of them, but didn't do a
systematic scan).

Bad idea
========

TpBaseChannelFillPropertiesFunc takes a GHashTable<string,GValue>.

tp_contact_attribute_map_take_sliced_gvalue takes a GValue.

tp_base_connection_dup_contact_attributes_hash returns a
GHashTable<string,GValue>.

tp_base_media_call_content_get_local_media_description returns some dbus-glib
thing.

TpBaseMediaCallStreamAddCandidatesFunc takes some dbus-glib thing.
tp_base_media_call_stream_set_stun_servers,
tp_base_media_call_stream_set_relay_info too.
tp_base_media_call_stream_get_local_candidates returns one.

tp_base_protocol_get_immutable_properties returns a{sv}.
TpBaseProtocol:immutable-properties is the same.

tp_base_protocol_new_connection takes an a{sv}.

TpBaseRoomConfigUpdateAsync takes an a{sv}?

tp_call_content_media_description_append_codec takes some dbus-glib thing.

tp_call_stream_endpoint_add_new_candidates, 
tp_call_stream_endpoint_add_new_candidate likewise.

tp_capabilities_get_channel_classes returns a{sv}s.
TpCapabilities:channel-classes is the same.

TpChannelManagerTypeChannelClassFunc, TpChannelManagerRequestFunc,
tp_channel_manager_create_channel, tp_channel_manager_ensure_channel,
tp_channel_manager_asv_has_unknown_properties.

tp_connection_manager_param_get_default has a parallel GVariant version
already, so it can probably be deleted.

TpDBusPropertiesMixin is entirely dbus-glib-based.

TpGroupMixin too.

Unrelated, but handle.h should talk about entity types, not handle types.

tp_message_set takes a GValue.

TpPresenceStatus has a dbus-glib data type, but should just have a boolean -
"allows message?" - since everything else that could go there is no longer in a
non-deprecated interface in 0.x, let alone 1.0.

Slightly odd
============

tp_account_get_avatar_finish() returns a GArray<guchar> which is OK but a bit
odd. I might replace it with GBytes?

Acceptable
==========

tp_base_call_channel_get_call_members() returns a GHashTable<guint,guint> which
is probably OK.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.