[Bug 76369] [next] Remove dbus-glib GTypes from public API

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Mar 31 09:00:54 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=76369

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Properties and signals:

Not OK
======

TpAccount:connection-error-details is an a{sv}. TpAccount::status-changed
contains the same.

TpBaseCallChannel:contents, TpBaseCallChannel:call-state-reason,
TpBaseCallChannel:call-state-details, TpBaseCallChannel:call-members,
TpBaseCallChannel:member-identifiers

TpBaseCallContent:streams

TpBaseCallStream:remote-members (but it would be fine with a different GType)

TpBaseCallStream:remote-member-identifiers (but it would be fine with a
different GType)

TpBaseConnectionManager:protocols (because it contains their properties)

TpBaseConnection:requestable-channel-classes

TpBaseConnection:dbus-status

TpBaseMediaCallContent:remote-media-descriptions,
TpBaseMediaCallContent:local-media-descriptions,
TpBaseMediaCallContent:media-description-offer,
TpBaseMediaCallContent::local-media-description-updated

TpBaseMediaCallStream:local-credentials,
TpBaseMediaCallStream:local-candidates, TpBaseMediaCallStream:stun-servers,
TpBaseMediaCallStream:relay-info, TpBaseMediaCallStream:endpoints (but it would
be OK with a different GType)

TpBasePasswordChannel:sasl-error-details (but it's internal anyway)

TpBaseProtocol:immutable-properties

TpCallContentMediaDescription:codecs, TpCallContentMediaDescription:ssrcs,
TpCallContentMediaDescription:header-extensions,
TpCallContentMediaDescription:feedback-messages

TpCallStreamEndpoint:remote-credentials,
TpCallStreamEndpoint:remote-candidates,
TpCallStreamEndpoint:selected-candidate-pairs,
TpCallStreamEndpoint:endpoint-state, TpCallStreamEndpoint::candidate-selected,
TpCallStreamEndpoint::candidate-accepted,
TpCallStreamEndpoint::candidate-rejected

TpCapabilities:channel-classes (but it also has channel-classes-variant)

TpChannelDispatchOperation:cdo-properties

TpChannel:channel-properties

TpChannel::group-members-changed (the details)

TpExportableChannel:channel-properties

TpExportableChannel's weird interaction with TpSvcChannel:closed

TpObserveChannelContext:observer-info

TpTextChannel:message-types (would be OK with a different GType)



Weird
=====

TpAccountRequest:avatar is a GArray of undocumented type (by inspection:
GArray<guchar>, which is a bit weird and a GBytes would probably be better).

----------------

Unrelated things I spotted:

TpHandleChannelContext:dbus-context (etc.) should probably be OBJECT rather
than POINTER now.

TpProtocol:avatar-requirements should be BOXED rather than POINTER?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list