[Bug 78376] remove tp_dbus_properties_mixin_class_init(), use "invisible mixin"

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri May 16 06:02:08 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=78376

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #3)
> The others CMs seem to be fine.

I assume you meant
<http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=next-invisible-mixin-78376>
instead of an unrelated branch. It looks good.

Your Gabble branch also looks good.

What about Mission Control, Folks, TPAW and Empathy? (Use git grep as a
starting point.)

Folks will probably need telepathy-glib tests/lib stuff copied into its
tests/lib/telepathy/contactlist/ (OK to commit that unreviewed, IMO).

(In reply to comment #3)
> Once this is merged we could consider
> removing tp_dbus_properties_mixin_class_init().

Sounds good. You'll need trivial changes (deleting the call) to all the CMs,
MC, Folks, and possibly TPAW and Empathy - I think it'd be OK to merge those
unreviewed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list