[Bug 78376] remove tp_dbus_properties_mixin_class_init(), use "invisible mixin"
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Fri May 16 06:34:07 PDT 2014
https://bugs.freedesktop.org/show_bug.cgi?id=78376
--- Comment #5 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #4)
> (In reply to comment #3)
> > The others CMs seem to be fine.
>
> I assume you meant
> <http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=next-
> invisible-mixin-78376> instead of an unrelated branch. It looks good.
Oops, indeed. :)
> Your Gabble branch also looks good.
Merged tp-glib and Gabble.
> What about Mission Control, Folks, TPAW and Empathy? (Use git grep as a
> starting point.)
MC is fine.
Folks just needs tests to be synced (which I did).
TPAW was not impacted.
The change in Empathy was trivial (one test) so I did it right away.
> (In reply to comment #3)
> > Once this is merged we could consider
> > removing tp_dbus_properties_mixin_class_init().
>
> Sounds good. You'll need trivial changes (deleting the call) to all the CMs,
> MC, Folks, and possibly TPAW and Empathy - I think it'd be OK to merge those
> unreviewed.
Still TODO.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the telepathy-bugs
mailing list