[next] telepathy-glib: tp_base_connection_dbus_request_handles: remove from public API

Simon McVittie smcv at kemper.freedesktop.org
Mon May 7 08:43:27 PDT 2012


Module: telepathy-glib
Branch: next
Commit: 1d4848ed469ecd536a975c064c73649ab5d5f292
URL:    http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=1d4848ed469ecd536a975c064c73649ab5d5f292

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Mon May  7 16:09:09 2012 +0100

tp_base_connection_dbus_request_handles: remove from public API

This function only existed for the benefit of some questionable
functionality in Gabble, which we removed back in 2009. Time for it
to go!

Reviewed-by: Xavier Claessens <xavier.claessens at collabora.co.uk>

---

 docs/reference/telepathy-glib-sections.txt |    1 -
 telepathy-glib/base-connection.c           |   17 +----------------
 telepathy-glib/base-connection.h           |    3 ---
 3 files changed, 1 insertions(+), 20 deletions(-)

diff --git a/docs/reference/telepathy-glib-sections.txt b/docs/reference/telepathy-glib-sections.txt
index 0aebf9c..02a6167 100644
--- a/docs/reference/telepathy-glib-sections.txt
+++ b/docs/reference/telepathy-glib-sections.txt
@@ -52,7 +52,6 @@ tp_base_connection_disconnect_with_dbus_error
 tp_base_connection_disconnect_with_dbus_error_vardict
 tp_base_connection_finish_shutdown
 tp_base_connection_add_interfaces
-tp_base_connection_dbus_request_handles
 TP_BASE_CONNECTION_ERROR_IF_NOT_CONNECTED
 tp_base_connection_register_with_contacts_mixin
 tp_base_connection_add_possible_client_interest
diff --git a/telepathy-glib/base-connection.c b/telepathy-glib/base-connection.c
index 597a29e..811134b 100644
--- a/telepathy-glib/base-connection.c
+++ b/telepathy-glib/base-connection.c
@@ -1628,22 +1628,7 @@ tp_base_connection_inspect_handles (TpSvcConnection *iface,
   g_free (ret);
 }
 
-/**
- * tp_base_connection_dbus_request_handles: (skip)
- * @iface: A pointer to #TpBaseConnection, cast to a pointer to
- *  #TpSvcConnection
- * @handle_type: The handle type (#TpHandleType) as a guint
- * @names: A strv of handle names
- * @context: The dbus-glib method invocation context
- *
- * Implements D-Bus method RequestHandles on interface
- * im.telepathy1.Connection. Exported so subclasses can
- * use it as a basis for their own implementations (for instance,
- * at the time of writing Gabble's GabbleConnection does its own processing
- * for room handles, in order to validate them asynchronously, but delegates
- * to this implementation for all other types).
- */
-void
+static void
 tp_base_connection_dbus_request_handles (TpSvcConnection *iface,
                                          guint handle_type,
                                          const gchar **names,
diff --git a/telepathy-glib/base-connection.h b/telepathy-glib/base-connection.h
index 7c1f88d..86d11fd 100644
--- a/telepathy-glib/base-connection.h
+++ b/telepathy-glib/base-connection.h
@@ -144,9 +144,6 @@ void tp_base_connection_finish_shutdown (TpBaseConnection *self);
 void tp_base_connection_add_interfaces (TpBaseConnection *self,
     const gchar **interfaces);
 
-void tp_base_connection_dbus_request_handles (TpSvcConnection *iface,
-    guint handle_type, const gchar **names, DBusGMethodInvocation *context);
-
 void tp_base_connection_register_with_contacts_mixin (TpBaseConnection *self);
 
 



More information about the telepathy-commits mailing list