[next] telepathy-glib: Don't include svc-*.h in "high-level" headers

Simon McVittie smcv at kemper.freedesktop.org
Mon May 7 08:43:27 PDT 2012


Module: telepathy-glib
Branch: next
Commit: fdaad090c77daf0cfa072926c82997f61f1345fd
URL:    http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=fdaad090c77daf0cfa072926c82997f61f1345fd

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Mon May  7 16:27:19 2012 +0100

Don't include svc-*.h in "high-level" headers

This involves a small loss of type-safety in TpBaseContactList, but
in practice the iface_init methods are used in a context that has
casts anyway, so there's no real loss.

This has the side-effect that we have to include dbus-properties-mixin.h
more often, because svc-connection.h indirectly included that.

Reviewed-by: Xavier Claessens <xavier.claessens at collabora.co.uk>

---

 telepathy-glib/base-connection-manager.c |    1 +
 telepathy-glib/base-connection-manager.h |    1 -
 telepathy-glib/base-connection.c         |    1 +
 telepathy-glib/base-connection.h         |    1 -
 telepathy-glib/base-contact-list.c       |   19 ++++++++++---------
 telepathy-glib/base-contact-list.h       |   10 +++-------
 telepathy-glib/base-protocol.h           |    1 +
 telepathy-glib/contacts-mixin.c          |    2 ++
 telepathy-glib/contacts-mixin.h          |    1 -
 telepathy-glib/debug-sender.c            |    1 +
 telepathy-glib/debug-sender.h            |    1 -
 telepathy-glib/group-mixin.c             |    1 +
 telepathy-glib/group-mixin.h             |    1 -
 telepathy-glib/message-mixin.c           |    1 +
 telepathy-glib/message-mixin.h           |    1 -
 telepathy-glib/presence-mixin.c          |    1 +
 telepathy-glib/presence-mixin.h          |    1 -
 tests/dbus/connection-balance.c          |    1 +
 tests/dbus/text-channel.c                |    1 +
 tests/lib/broken-client-types-conn.c     |    1 +
 tests/lib/bug-19101-conn.c               |    1 +
 tests/lib/contacts-conn.c                |    1 +
 tests/lib/contacts-conn.h                |    1 +
 tests/lib/simple-conn.c                  |    1 +
 24 files changed, 29 insertions(+), 23 deletions(-)

Diff:   http://cgit.freedesktop.org/telepathy/telepathy-glib/diff/?id=fdaad090c77daf0cfa072926c82997f61f1345fd


More information about the telepathy-commits mailing list