[Telepathy] Spec changes: tube API

[Guillaume Desmottes]

Le jeudi 19 juillet 2007 à 14:45 +0100, Simon McVittie a écrit :
> Tube_Stream_Address_Type::Unix: Should the socket path really be 's'?
> Filesystem paths aren't guaranteed to be UTF-8 (or any other particular
> encoding) so perhaps we should use 'ay'. Also, instead of saying
> "string" I'd prefer it if you said "string (signature 's')" or
> "byte array (signature 'ay')".
> 
> Tube_Stream_Address_Type::Abstract_Unix: likewise.
> 
> Tube_Stream_Address_Type::TCP: Shouldn't it be called IP or IPv4, so we
> can use the same enum when we implement UDP tubes later?
> 
> When there's an a{sv} of tube parameters, we should explicitly say that
> the parameters are defined by the service (i.e. CMs should support
> arbitrary parameters). We should define a baseline set of types which
> CMs must support - in practice Gabble currently supports 's', 'ay',
> 'i', 'u', 'n' and 'q', it appears.
> 
> Perhaps we should suggest that for stream tubes, we recommend that the
> parameters are the same as in a _whatever._tcp TXT record in DNS-SD.
> 
> Are we sure we want to use a single struct "(uv)" to represent
> stream addresses? It would be more consistent with the
> handle-type/handle pairs elsewhere in the Tp API if we used two separate
> arguments of type "u" and "v". Also, this would avoid some tedious
> GValue manipulation when using dbus-glib :-)
> 
> <arg direction="out" name="address" type="uv"> is clearly wrong - "uv"
> is not a single complete type. It should either be "(uv)" or two
> parameters of types "u" and "v", depending whether you agree with my
> previous paragraph.


All these comments are fixed in
http://projects.collabora.co.uk/~monkey/spec-stream-tubes-smcv/ 

Rob, did you finish your review of this ?
Any other comment/suggestion ?


	G.