[Telepathy] Standardising Mission Control

Alberto Mardegan mardy at users.sourceforge.net
Fri Jun 15 04:08:38 PDT 2007


ext Xavier Claessens wrote:
> I attached a first patch for MC, I did not tested it. Just to know if
> it's the right way for implementing that functionality.

As far as I can see, it's the right way to implement it. But I can 
imagine of some problems arising when one filter doesn't emit the 
Process signal: if the filters dies before emitting it, your patch 
correctly removes the filter from the chain, but processing of the 
channel will not be resumed.

Maybe in _on_filter_proxy_destroy() we could get the "table" from the 
proxy and call mcd_dispatcher_context_process (ctx, FALSE) on all the 
contexts.
This implies that we should remove the context from the table before 
_on_filter_process returns (which should probably be done anyway).

We should also consider the case when MC exits while a filter is 
processing a channel, but at a first thought I see no problems in that.

Ciao,
   Alberto

-- 
http://www.mardy.it <-- Geek in un lingua international!


More information about the Telepathy mailing list