[Telepathy] [Bug 12465] Current avatars API is likely to generate too much DBus traffic

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=12465





------- Comment #8 from mikhail.zabaluev at nokia.com  2007-11-28 01:42 PST -------
(In reply to comment #7)
> And CM should wait a bit when receiving RequestAvatars() because it's likely to
> get one request from many clients at once, so it could emit AvatarRetrieved
> only once with all avatars requested.

You know it's broken when 1) clients are expected to implement caching on top
of what's already done by CMs, and 2) a CM should jump through hoops to
implement it efficiently.

I propose deprecating RequestAvatars for a new method that returns the
available avatars immediately; let's name it LookupAvatars for purposes of the
discussion. If an avatar is immediately available, it's returned right away in
an array of avatar tuples. Otherwise, avatar retrieval is initiated and
AvatarRetrieved is emitted when the avatar is available.
This way, we can avoid the race between AvatarRetrieved and RequestAvatars for
the same handle invoked by concurrent clients, which may result in redundant
emissions of AvatarRetrieved.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.