[Telepathy] [Bug 17751] New: BaseConnection:: self_handle should not be set to 0 before the object is disposed

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=17751

           Summary: BaseConnection::self_handle should not be set to 0
                    before the object is disposed
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: telepathy-glib
        AssignedTo: telepathy at lists.freedesktop.org
        ReportedBy: will.thompson at collabora.co.uk


Currently, BaseConnection::self_handle is set to 0 just before
status-changed(Disconnected, …) is emitted, and in 0.17.16 it will change
just after status-changed(Disconnected, …) is emitted to allow
ChannelManagers listening for that signal to use the self_handle.

Ideally, the self_handle would be valid until the BaseConnection is disposed,
but CMs may wrongly depend on it being 0 by the time the dispose method for
their subclass of TpBaseConnection is called.  (For instance, Gabble asserts
that it is 0.)  We should audit and fix all known connection managers, then
move the unreffing to dispose.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.