[Telepathy] [Bug 19683] Refactor Capabilities/ContactCapabilities to make sense

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=19683





--- Comment #2 from Alban Crequy <alban.crequy at collabora.co.uk>  2009-09-04 11:30:13 PST ---
(In reply to comment #1)
> Will and I have refactored Capabilities extensively. Review would be
> appreciated.

I have only a few comments after such a big branch :-)


src/ft-channel.c
+      /* FIXME: should we check for SI, bytestreams and/or IBB too? */
--> Reply to the question or open a bug for that.

src/capabilities.c
gsize feature_handles_refcount = 0;
--> What isn't it static?

src/presence.c
  if (priv->cap_set == NULL)
    { 
      tmp = gabble_capability_set_dump (priv->cap_set, "  ");
--> do you mean '!=' instead of '==' ?  (2 occurences of this pattern in this
file)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.