[Telepathy] [Bug 19683] Refactor Capabilities/ContactCapabilities to make sense

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=19683


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|patch                       |




--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-09-07 08:08:03 PST ---
(In reply to comment #2)
> src/ft-channel.c
> +      /* FIXME: should we check for SI, bytestreams and/or IBB too? */
> --> Reply to the question or open a bug for that.

I'll open a bug, unless Guillaume can insta-answer it...

> src/capabilities.c
> gsize feature_handles_refcount = 0;
> --> What isn't it static?

A very good question. It should be.

> src/presence.c
>   if (priv->cap_set == NULL)
>     { 
>       tmp = gabble_capability_set_dump (priv->cap_set, "  ");
> --> do you mean '!=' instead of '==' ?  (2 occurences of this pattern in this
> file)

Yes, you're right.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.