[Telepathy] [Bug 19683] Refactor Capabilities/ContactCapabilities to make sense
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Mon Sep 7 08:24:58 PDT 2009
http://bugs.freedesktop.org/show_bug.cgi?id=19683
Simon McVittie <simon.mcvittie at collabora.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |patch
--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2009-09-07 08:24:58 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > src/ft-channel.c
> > + /* FIXME: should we check for SI, bytestreams and/or IBB too? */
> > --> Reply to the question or open a bug for that.
>
> I'll open a bug, unless Guillaume can insta-answer it...
Bug #23777.
> > src/capabilities.c
> > gsize feature_handles_refcount = 0;
> > --> What isn't it static?
> A very good question. It should be.
Fixed in the branch; make check is re-running now.
(en_FR check: "Why" should have been "What" in your review comment :-)
> > src/presence.c
> [...]
> Yes, you're right.
Fixed in the branch; make check is re-running now.
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the telepathy
mailing list