[Telepathy] Telepathy/Empathy improvements for Gnome Shell

Sjoerd Simons sjoerd.simons at collabora.co.uk
Mon Nov 15 07:31:47 PST 2010


On Mon, 2010-11-15 at 14:30 +0000, Simon McVittie wrote:
> On Mon, 15 Nov 2010 at 14:08:48 +0000, Sjoerd Simons wrote:
> > Also can we use Preferred_Handler instead of Next_Handler and allow it
> > to be an empty string?
> 
> That was my plan, yes; using the same argument name would make that
> clearer, though, so I'll do that.

Cool

> > Last part of my small bike-shed, i wonder if it's worth for it to return
> > a ChannelRequest so it's basically really just EnsureChannelWithHints
> > without the request time properties. Just so all the interfaces we add
> > over time to ChannelRequest can be easily applied to this
> 
> Only if it's acceptable to require its caller to call Proceed.

> I'm not sure that this really "looks like" a ChannelRequest - in the
> current MC codebase it would basically be an off-bus McdDispatchOperation, in
> fact. I'd be inclined to prototype it without the ChannelRequest, then look
> at the resulting code and think about whether a ChannelRequest would make
> sense.

I guess, it's not so much for the MC implementation but more for clients
and developers to just have this method follow a pattern that they're
already used to.. But i could go either way really

-- 
Sjoerd Simons <sjoerd.simons at collabora.co.uk>
Collabora Ltd.


More information about the telepathy mailing list