[Telepathy] Mission-Control tests fail without connman being online
simon.mcvittie at collabora.co.uk
Tue May 7 05:08:48 PDT 2013
On 07/05/13 08:55, Reto Zingg wrote:
> My understanding is that fakeconnectivity.py should "play" connman on
> the temporary session dbus.
This is how it works during "make check". It emulates both ConnMan and
NetworkManager (simultaneously!), in fact. We set
DBUS_SYSTEM_BUS_ADDRESS="$DBUS_SESSION_BUS_ADDRESS" when executing MC,
so that MC thinks the fake session bus is the real system bus.
> And the tests should not depend on any real network being available.
This is how it works during "make check".
> I run the tests with the run-test.sh script
Is this using --enable-installed-tests (which you might remember us
using for CITA in Maemo)? If so, you will probably have to support it
yourself if you want it. The configuration we test ourselves (i.e. the
one I ran when making the releases) is "make check" and "make
distcheck", running the tests inside the built tree. This is also
somewhat more thorough than the installed tests, because we use a debug
version of MC that can be manipulated by the tests.
It is entirely possible that the installed tests are broken in
situations where ConnMan doesn't think you have connectivity: MC
(correctly!) refuses to go online there. You might need to run the MC
tests with a fake ConnMan that always says "yes, I am online".
My patches on https://bugs.freedesktop.org/show_bug.cgi?id=56635 might
improve matters for the installed tests, if someone reviews them (and
"real-world" testing demonstrates that they actually work).
More information about the telepathy