[VDPAU] Extend Flash workaround for Opera and Konqueror

Anssi Hannula anssi at mageia.org
Thu Jan 24 23:56:00 PST 2013


18.01.2013 18:22, Stephen Warren kirjoitti:
> James Le Cuirot wrote at Friday, January 18, 2013 2:29 AM:
>> A patch that extends the existing Flash workaround for Opera and
>> Konqueror was written by Anssi Hannula, a Mageia developer, but I can't
>> see any evidence that it was sent back upstream so I'd just like to
>> make sure that this happens. Please see the patch in their repository.
>>
>> http://svnweb.mageia.org/packages/updates/2/libvdpau/current/SOURCES/libvdpau-workaround-flashplayer-
>> konq-opera.patch?view=markup

Oops, sorry for not posting the patch here. I didn't realize at the time
that such workarounds were actually going to be pushed to libvdpau
proper, and forgot it.

> It might be best to rework that patch to split init_running_under_flash()
> into 3 functions; one which checks /proc/self/cmdline, one which checks
> /proc/self/comm, and another which checks /proc/self/maps. The way, if
> any of the error handling triggers e.g. while checking /proc/self/cmdline,
> it won't cause the code to check e.g. /proc/self/comm to be skipped.
> 
> Using strstr() would be slightly less efficient for the /proc/self/maps
> check, but would make the code a lot simpler.

+1 for both, I'll post an updated patch soon (it may be a while, I'm
quite busy right now).

-- 
Anssi Hannula


More information about the VDPAU mailing list