[VDPAU] [PATCH] Add detection for multiple flash substrings

[Aaron Plattner]

On 05/20/2015 07:24 AM, Emil Velikov wrote:
> On 20 May 2015 at 14:19, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 20 May 2015 at 07:25, Sergey Frolov <dunkan.aidaho at gmail.com> wrote:
>
>>> +            strncpy(*signature, param, strlen(param));
>> The last (terminating null) byte seems to be uninitialised.
> Please ignore this. I was reading it as memcpy :-\

strncpy(..., str, strlen(str)) is basically just strcpy(). But in this 
case it's okay because the string is allocated to be the correct size.

But please simplify this code by just using strdup() instead. :)

I think the main problem I have with this change is that it requires 
users to add the new flash_process lines to /etc/vdpau_wrapper.cfg or 
else existing configurations will break. Can the new configuration be 
added without removing the existing "libflashplayer" hard-code?

You could solve the "maximum number of flash_process lines" problem and 
also simplify the memory management if instead of storing all of the 
flash_process lines, you just made made init_running_under_flash() save 
the command line string and had init_config() check each flash_process 
line against that.

> -Emil

-- 
Aaron