[virglrenderer-devel] [PATCH 2/4] vrend_shader: generate bindings with layout qualifiers

[Erik Faye-Lund]

On 07. aug. 2018 02:51, Dave Airlie wrote:
> On 7 August 2018 at 04:38, Erik Faye-Lund <erik.faye-lund at collabora.com> wrote:
>> OpenGL ES 3.1 doesn't support using glUniform1i() for binding
>> images, so let's use layout qualifiers instead. This should in
>> theory be slightly more performant as well, as we do less API
>> calls.
> I like this idea, I think we can get rid of a bunch of stuff with
> explicit bindings,
>
> However I think explicit layout bindings on GL require a shader extension,
>
> At least on desktop GL a lot of tests fail after I apply this.
>
> Dave.

Hmm, that's odd. I don't think there's any extensions that should be 
required by this, but I'll take a look.

Thanks for pointing this out.