[virglrenderer-devel] [PATCH 0/2] Fix dEQP multisample_interpolation.* failures

[Erik Faye-Lund]

I forgot to mention, these are against Dave Airlie's gl-4.3 tree.


On 03. juli 2018 09:08, Erik Faye-Lund wrote:
> We currently only respect the TGSI_INTERPOLATE_LOC_CENTROID specifier
> for inputs, which leads to a bunch of dEQP failures. We need not only
> to add the "centroid"-keyword to the inputs, but also "sample" if the
> specifier is TGSI_INTERPOLATE_LOC_SAMPLE.
>
> This is a bit trickier than other cases, due to the fact that "sample"
> requires GLSL 4.00 (or GL_ARB_gpu_shader5, which the rest of the shader
> generator uses instead) combined with our approach to patching up shader
> outputs in vertex, geometry or tesselation control shaders, to match the
> fragment shader.
>
> This series reserves space for the extension-require in the shader-kinds
> that might need patching, so we can easily inject it later on.
>
> This fixes the following tests:
>
> dEQP-GLES31.functional.shaders.multisample_interpolation.sample_qualifier.multisample_texture_1
> dEQP-GLES31.functional.shaders.multisample_interpolation.sample_qualifier.multisample_texture_2
> dEQP-GLES31.functional.shaders.multisample_interpolation.sample_qualifier.multisample_texture_4
> dEQP-GLES31.functional.shaders.multisample_interpolation.sample_qualifier.multisample_texture_8
> dEQP-GLES31.functional.shaders.multisample_interpolation.sample_qualifier.multisample_texture_16
> dEQP-GLES31.functional.shaders.multisample_interpolation.sample_qualifier.multisample_rbo_1
> dEQP-GLES31.functional.shaders.multisample_interpolation.sample_qualifier.multisample_rbo_2
> dEQP-GLES31.functional.shaders.multisample_interpolation.sample_qualifier.multisample_rbo_4
> dEQP-GLES31.functional.shaders.multisample_interpolation.sample_qualifier.multisample_rbo_8
> dEQP-GLES31.functional.shaders.multisample_interpolation.sample_qualifier.multisample_rbo_16
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.at_sample_id.multisample_texture_1
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.at_sample_id.multisample_texture_2
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.at_sample_id.multisample_texture_4
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.at_sample_id.multisample_texture_8
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.at_sample_id.multisample_texture_16
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.at_sample_id.multisample_rbo_1
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.at_sample_id.multisample_rbo_2
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.at_sample_id.multisample_rbo_4
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.at_sample_id.multisample_rbo_8
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.at_sample_id.multisample_rbo_16
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_offset.at_sample_position.multisample_texture_1
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_offset.at_sample_position.multisample_texture_2
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_offset.at_sample_position.multisample_texture_4
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_offset.at_sample_position.multisample_texture_8
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_offset.at_sample_position.multisample_texture_16
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_offset.at_sample_position.multisample_rbo_1
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_offset.at_sample_position.multisample_rbo_2
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_offset.at_sample_position.multisample_rbo_4
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_offset.at_sample_position.multisample_rbo_8
> dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_offset.at_sample_position.multisample_rbo_16
>
> Erik Faye-Lund (2):
>    pad shaders with space for GL_ARB_gpu_shader5 it's needed
>    emit sample-keyword
>
>   src/vrend_shader.c | 78 ++++++++++++++++++++++++++++++++++++----------
>   src/vrend_shader.h |  3 +-
>   2 files changed, 63 insertions(+), 18 deletions(-)
>