[virglrenderer-devel] [PATCH v2] make sure both shift-operands are the same size
airlied at gmail.com
Thu Jul 5 00:25:20 UTC 2018
On 4 July 2018 at 22:00, Erik Faye-Lund <erik.faye-lund at collabora.com> wrote:
> On 04. juli 2018 11:37, Erik Faye-Lund wrote:
>> Changes since last round:
>> Fixed the piglit regression in fs-op-assign-lshift-ivec3-int.shader_test
>> (and probably the rest,
>> will run a full set of tests soon).
> Yep, confirmed. Regressions are gone.
Actually this is the wrong answer to this problem.
But we have the same bug in a few ways,
The problem is TGSI gives us a system value like
then we translate the to
gl_SampleMask instead of
uvec4(gl_SampleMask, gl_SampleMask, gl_SampleMask, gl_SampleMask)
I've fixed this previously for some of the other system values and I
think the same
fix is required here.
More information about the virglrenderer-devel