[virglrenderer-devel] [PATCH] fixup typo in SHADER_REQ_GPU_SHADER5 logic

Erik Faye-Lund erik.faye-lund at collabora.com
Mon Jul 9 14:34:28 UTC 2018


In 0ea74890db8d7160e94488e0e35c9cbdd76ced23, I had a typo that
made GL_ARB_gpu_shader5 being injected into vertex-shaders that
doesn't need them.

This is obviously a big problem when running on for instance GLES
2.0, where this extension isn't supported. So let's fix this.

Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
---
This fixes problems getting X11 to even start up on GLES2.

 src/vrend_shader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/vrend_shader.c b/src/vrend_shader.c
index 6d946f9..1c666e7 100644
--- a/src/vrend_shader.c
+++ b/src/vrend_shader.c
@@ -558,7 +558,7 @@ iter_declaration(struct tgsi_iterate_context *iter,
       ctx->inputs[i].glsl_gl_block = false;
 
       if (iter->processor.Processor == TGSI_PROCESSOR_FRAGMENT &&
-          decl->Interp.Interpolate == TGSI_INTERPOLATE_LOC_SAMPLE) {
+          decl->Interp.Location == TGSI_INTERPOLATE_LOC_SAMPLE) {
          ctx->shader_req_bits |= SHADER_REQ_GPU_SHADER5;
          ctx->has_sample_input = true;
       }
-- 
2.18.0.rc2



More information about the virglrenderer-devel mailing list