[virglrenderer-devel] [PATCH 4/5] add a cap for TGSI precise modifiers

[Erik Faye-Lund]

On 13. juli 2018 17:50, Gurchetan Singh wrote:
> On Thu, Jul 12, 2018 at 12:56 AM Erik Faye-Lund
> <erik.faye-lund at collabora.com> wrote:
>> This way, mesa can know that the TGSI-parser groks the _PRECISE
>> modifier, and it doesn't need to cull them any more.
>>
>> Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
>> ---
>>   src/virgl_hw.h       | 1 +
>>   src/vrend_renderer.c | 2 +-
>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/virgl_hw.h b/src/virgl_hw.h
>> index 44c7108..bbd4d38 100644
>> --- a/src/virgl_hw.h
>> +++ b/src/virgl_hw.h
>> @@ -215,6 +215,7 @@ enum virgl_formats {
>>   #define VIRGL_CAP_NONE 0
>>   #define VIRGL_CAP_TGSI_INVARIANT       (1 << 0)
>>   #define VIRGL_CAP_TEXTURE_VIEW         (1 << 1)
>> +#define VIRGL_CAP_TGSI_PRECISE         (1 << 2)
> Is there a Mesa side patch that makes use of VIRGL_CAP_TGSI_PRECISE?
> We don't really do anything with VIRGL_CAP_TGSI_INVARIANT, even though
> send over the wire.  Can you send out a patch that makes use of both
> of them?

Yes, I have a branch for that, I should of course have mentioned this in 
the cover-letter:

https://gitlab.freedesktop.org/kusma/mesa/tree/virgl-precise

I noticed that we don't do anything for invariant, but I don't know what 
we'd want to do... I wasn't involved in the patches that introduced that 
feature, so I don't really know what went on.

>>   struct virgl_caps_bool_set1 {
>>           unsigned indep_blend_enable:1;
>> diff --git a/src/vrend_renderer.c b/src/vrend_renderer.c
>> index cc99087..388f08d 100644
>> --- a/src/vrend_renderer.c
>> +++ b/src/vrend_renderer.c
>> @@ -7550,7 +7550,7 @@ void vrend_renderer_fill_caps(uint32_t set, uint32_t version,
>>
>>      caps->v1.max_samples = vrend_renderer_query_multisample_caps(max, &caps->v2);
>>
>> -   caps->v2.capability_bits |= VIRGL_CAP_TGSI_INVARIANT;
>> +   caps->v2.capability_bits |= VIRGL_CAP_TGSI_INVARIANT | VIRGL_CAP_TGSI_PRECISE;
>>
>>      if (gl_ver >= 43 || epoxy_has_gl_extension("GL_ARB_texture_view"))
>>         caps->v2.capability_bits |= VIRGL_CAP_TEXTURE_VIEW;
>> --
>> 2.18.0.rc2
>>
>> _______________________________________________
>> virglrenderer-devel mailing list
>> virglrenderer-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel