[virglrenderer-devel] [PATCH v2 0/4] tesselation fixes

[Erik Faye-Lund]

On 18. juli 2018 18:50, Gurchetan Singh wrote:
> On Wed, Jul 18, 2018 at 1:41 AM Erik Faye-Lund
> <erik.faye-lund at collabora.com> wrote:
>> Here's a respin of the rest of the tesselation fixes series.
>>
>> Changes since v1:
>> - The first patch was merged to master
>> - The series has been rebased, due to conflicts because of
>>    other patches.
>>
>> This series fixes the following dEQP-GLES31 tests, when combined with
>> the experimental gl-4.5 from Dave:
>>
>> - dEQP-GLES31.functional.tessellation.common_edge.triangles_equal_spacing_precise
>> - dEQP-GLES31.functional.tessellation.common_edge.triangles_fractional_odd_spacing_precise
>> - dEQP-GLES31.functional.tessellation.common_edge.triangles_fractional_even_spacing_precise
>> - dEQP-GLES31.functional.tessellation.common_edge.quads_equal_spacing_precise
>> - dEQP-GLES31.functional.tessellation.common_edge.quads_fractional_odd_spacing_precise
>> - dEQP-GLES31.functional.tessellation.common_edge.quads_fractional_even_spacing_precise
>>
>> However, we already support the functionality this corrects on master,
>> so it'd be nice to get it included there...
>>
>> Erik Faye-Lund (2):
>>    add a cap for TGSI precise modifiers
>>    emit precise keyword
>>
>> Karol Herbst (2):
>>    tgsi: populate precise
>>    tgsi/text: parse _PRECISE modifier
>>
>>   src/gallium/auxiliary/tgsi/tgsi_build.c |  3 +++
>>   src/gallium/auxiliary/tgsi/tgsi_text.c  | 17 ++++++++++++++---
>>   src/gallium/auxiliary/tgsi/tgsi_ureg.c  |  8 +++++++-
>>   src/gallium/auxiliary/tgsi/tgsi_ureg.h  | 20 +++++++++++++++++++-
>>   src/virgl_hw.h                          |  1 +
>>   src/vrend_renderer.c                    |  2 +-
>>   src/vrend_shader.c                      | 25 +++++++++++++++++++++----
>>   7 files changed, 66 insertions(+), 10 deletions(-)
>
> This series is:
>
> Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>
>
> It looks like there's a merge conflict in patch 3 (with
> VIRGL_CAP_COPY_IMAGE), but that should be simple to rebase when
> committing.

Thanks. In case a maintainer wants to merge this, I've pushed a rebased 
version with your r-b on it here:

https://gitlab.freedesktop.org/kusma/virglrenderer/tree/tesselation-fixes-v3