[virglrenderer-devel] [PATCH v2 2/4] protect call to glDeleteSamplers

Erik Faye-Lund erik.faye-lund at collabora.com
Fri Jul 20 08:03:41 UTC 2018


Otherwise, it'd be possible to generate evil commands from a rouge
guest-driver that can crash the VM.

Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
---
 src/vrend_renderer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/vrend_renderer.c b/src/vrend_renderer.c
index 78aa252..8d5f51d 100644
--- a/src/vrend_renderer.c
+++ b/src/vrend_renderer.c
@@ -1354,7 +1354,8 @@ static void vrend_destroy_sampler_state_object(void *obj_ptr)
 {
    struct vrend_sampler_state *state = obj_ptr;
 
-   glDeleteSamplers(1, &state->id);
+   if (vrend_state.have_samplers)
+      glDeleteSamplers(1, &state->id);
    FREE(state);
 }
 
-- 
2.18.0



More information about the virglrenderer-devel mailing list