[virglrenderer-devel] [RFC PATCH 1/7] vrend: remove superflous caps initialization

Gert Wollny gert.wollny at collabora.com
Mon Jul 23 10:55:37 UTC 2018


Am Montag, den 23.07.2018, 12:41 +0200 schrieb Erik Faye-Lund:
> 
> On 23. juli 2018 12:37, Gert Wollny wrote:
> > The field is memset to zero at the beginning, so there is mo need
> > to clear each flag seperately.
> > 
> > 
> > -   caps->v1.max_viewports = 1;
> > -
> 
> This last one seems to change behavior; this is the gles-path, and 
> there's no other initialization of max_viewports there AFAICT...
That's true, it corrected in a later patch when the code path are
unified, but of course, to be able to bisect it shouldn't be removed
here.  

thanks, 
Gert 



More information about the virglrenderer-devel mailing list