[virglrenderer-devel] [PATCH v2 3/4] discourage using legacy-definitions

[Erik Faye-Lund]

This copy of the bind-flags should not be used, as they are a duplicate
set of what can already be found in virgl_hw.h.

But to avoid breaking theoretical, unknown users, we shouldn't remove
them either. So let's just add a comment to tell people not to use
them.

Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
---
 src/virglrenderer.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/virglrenderer.h b/src/virglrenderer.h
index 5baecdd..b63d653 100644
--- a/src/virglrenderer.h
+++ b/src/virglrenderer.h
@@ -79,8 +79,10 @@ VIRGL_EXPORT void virgl_renderer_get_rect(int resource_id, struct iovec *iov, un
 VIRGL_EXPORT int virgl_renderer_get_fd_for_texture(uint32_t tex_id, int *fd);
 VIRGL_EXPORT int virgl_renderer_get_fd_for_texture2(uint32_t tex_id, int *fd, int *stride, int *offset);
 
-/* virgl bind flags - these are compatible with mesa 10.5 gallium.
-   but are fixed, no other should be passed to virgl either. */
+/*
+ * These are only here for compatibility-reasons. In the future, use the flags
+ * from virgl_hw.h instead.
+ */
 #define VIRGL_RES_BIND_DEPTH_STENCIL (1 << 0)
 #define VIRGL_RES_BIND_RENDER_TARGET (1 << 1)
 #define VIRGL_RES_BIND_SAMPLER_VIEW  (1 << 3)
-- 
2.18.0