[virglrenderer-devel] features rework part 3 (ignore part 2)

[Dave Airlie]

On 24 July 2018 at 19:48, Gert Wollny <gert.wollny at collabora.com> wrote:
> Am Dienstag, den 24.07.2018, 13:38 +1000 schrieb Dave Airlie:
>> This contains the part 2 work in it, and moves nearly all the
>> remaining code to using the features frameworks and tries to
>> clamp down any places we might access a GL API that isn't applicable
>> to the framework.
>>
>> This series doesn't always dtrt for GLES3 hosts so I suspect,
>> we will need a rebase/rework of Gert's code once this lands.
>>
>> I also need to test this a bit more, I suspect.
> On GLES there are regressions for all of
>
>   dEQP-GLES3.functional.transform_feedback.*
> This is probably not enabled at all, but when I add 30 as minial gles
> version I also get only failures, t tells me that transform feedback is
> already active.
>
>   dEQP-GLES3.functional.clipping.point.wide_point_z_clip*
>
> and most of
>   dEQP-GLES3.functional.ubo.*
>
> I did a bad review there, see additional comment to patch,
>

Thanks, I've pushed the series with your r-b's where you gave them
and all the GLES changes hopefully done.

I think we now need to turn to fixing up the fill caps using your patches
I think we can make most of it generic now using features to enable
caps whether GLES or GL.

Dave.