[virglrenderer-devel] [RFC PATCH] vtest: Add backing store to each resource

[Dave Airlie]

On 31 July 2018 at 00:27, Tomeu Vizoso <tomeu.vizoso at collabora.com> wrote:
> With the main aim of making vtest's usage of virglrenderer more similar
> to that of QEMU, this patch sets a backing store to each resource and
> reads from or writes to at each transfer operation.
>
> ---
>
> Standing issues:
>
> - Doesn't address compatibility with the mesa side. Can we assume the
> user of vtest knows which Mesa version to use?

Not really, I'd like to keep vtest working across stuff for bisection reasons,
however I'd be willing to accept one break to add proper versioning :-)

>
> - The backing store isn't released. Should we add a callback from
> vrend_renderer_resource_destroy?

Sounds about right.

>
> - There's the problem with the offset passed to the transfer API
> pointing to the first pixel that Mesa is interested in, but the size arg
> refers to whole lines/layers.

Not sure I'm awake enough to comment on this yet.

Dave.