[virglrenderer-devel] [PATCH v3 0/7] re-unify caps GL and GLES evaluation code path (2 part)

[Gert Wollny]

Am Montag, den 30.07.2018, 18:06 -0700 schrieb Gurchetan Singh:
> With a rebase,
> 

thanks for reviewing, 

After looking into what's involved with the rebase I think I will wait
until Dave's computer shader work has landed and the new caps are all
in place. I will have to redo the last three patches, but this is just
trivially moving code blocks. 

best, 
Gert

 Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>
> On Mon, Jul 30, 2018 at 6:01 AM Gert Wollny <gert.wollny at collabora.co
> m> wrote:
> > 
> > Dear all,
> > 
> > this updates the patches that have not yet been pushed and adds
> > some more
> > changes to accommodate Gurchetan suggestion that similar types of
> > caps are
> > filled in within the same function.
> > 
> > In summary, now we have one function for evaluating the glsl
> > version, one to
> > fill in the caps v1, and one for caps v2.
> > 
> > There is of course a conflict with Dave's image patches that also
> > add new caps,
> > but this rebasing should be trivial.
> > 
> > Many thanks for reviewing,
> > Gert
> > 
> > Gert Wollny (7):
> >   vrend,caps: move version-less common caps into common functions
> >   vrend,caps: Unify feature code path and remove duplicates
> >   vrend,caps: Add GLES entry for gl_prim_restart
> >   vrend,caps: unify GLSL version evaluation
> >   vrend,caps: evaluate GLSL version before everything else
> >   vrend,caps: move all caps for version 1 into one function
> >   vrend,caps: Move all v2 caps into according function
> > 
> >  src/vrend_renderer.c | 271 +++++++++++++++++++------------------
> > --------------
> >  1 file changed, 102 insertions(+), 169 deletions(-)
> > 
> > --
> > 2.16.4
> > 
> > _______________________________________________
> > virglrenderer-devel mailing list
> > virglrenderer-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel
> 
> _______________________________________________
> virglrenderer-devel mailing list
> virglrenderer-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel