[virglrenderer-devel] [PATCH 2/4] vrend_shader: use conversion table in iter_instruction

[Dave Airlie]

I've pushed these, but found and fixed two regressions, just logging
them here for prosperity.

On 31 May 2018 at 11:43, Gurchetan Singh <gurchetansingh at chromium.org> wrote:
> This commit uses the get_string() helper to convert various
> enums to prefixes / conversion strings.
>
> v2: In certain cases, FLOAT_BITS_TO_UINT --> FLOAT_BITS_TO_INT (Elie)
> ---
>  src/vrend_shader.c | 210 ++++++++++++++++++++++-----------------------
>  1 file changed, 103 insertions(+), 107 deletions(-)
>
> diff --git a/src/vrend_shader.c b/src/vrend_shader.c

> @@ -1996,14 +1994,14 @@ iter_instruction(struct tgsi_iterate_context *iter,
>              return FALSE;
>           if (inst->Instruction.Opcode == TGSI_OPCODE_INTERP_SAMPLE && i == 1) {
>              stprefix = true;
> -            stypeprefix = "floatBitsToInt";
> +            stypeprefix = FLOAT_BITS_TO_UINT;
>           }

This goes from FBTOI to FBTOUI - breaks some interpolateSample tests,
I fixed this up.

Dave.