[virglrenderer-devel] [PATCH 3/3] vrend_shader: add arb_gpu_shader_fp64 support

Gurchetan Singh gurchetansingh at chromium.org
Mon Jun 4 19:59:53 UTC 2018


Which commands are you using to test this?  Every fp64 Piglit test I run is
skipped (though I am a Piglit newbie):

~/piglit$ ./bin/arb_gpu_shader_fp64-tf-interleaved-aligned
libGL error: MESA-LOADER: failed to retrieve device information
MESA-LOADER: failed to retrieve device information
MESA-LOADER: failed to retrieve device information
Test requires GL_ARB_gpu_shader_fp64
PIGLIT: {"result": "skip" }

Are there any guest side changes also needed?


On Thu, May 31, 2018 at 7:04 PM Dave Airlie <airlied at gmail.com> wrote:

> > @@ -1887,7 +1930,8 @@ static int
> >  get_source_info(struct dump_ctx *ctx,
> >                  const struct tgsi_full_instruction *inst,
> >                  struct source_info *sinfo,
> > -                char srcs[3][255], char src_swizzle0[10])
> > +                char srcs[3][255], char src_swizzle0[10],
> > +                char fp64_srcs[3][255])
>
> Self-review: don't need to pass fp64_srcs in here, it can be local to this.
>
> Dave.
> _______________________________________________
> virglrenderer-devel mailing list
> virglrenderer-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/virglrenderer-devel/attachments/20180604/3b94ca5c/attachment-0001.html>


More information about the virglrenderer-devel mailing list