[virglrenderer-devel] [PATCH 3/3] vrend_shader: add arb_gpu_shader_fp64 support

Dave Airlie airlied at gmail.com
Mon Jun 4 20:10:13 UTC 2018


On 5 June 2018 at 05:59, Gurchetan Singh <gurchetansingh at chromium.org> wrote:
> Which commands are you using to test this?  Every fp64 Piglit test I run is
> skipped (though I am a Piglit newbie):
>
> ~/piglit$ ./bin/arb_gpu_shader_fp64-tf-interleaved-aligned
> libGL error: MESA-LOADER: failed to retrieve device information
> MESA-LOADER: failed to retrieve device information
> MESA-LOADER: failed to retrieve device information
> Test requires GL_ARB_gpu_shader_fp64
> PIGLIT: {"result": "skip" }
>
> Are there any guest side changes also needed?

Oh sorry there is one mesa patch to enable doubles.

https://cgit.freedesktop.org/~airlied/mesa/commit/?h=virgl-fp64&id=f47a495868a741a5263e259d01ba127a48bf9181

rebased onto master, I should send that out as well.

Dave.

>
>
> On Thu, May 31, 2018 at 7:04 PM Dave Airlie <airlied at gmail.com> wrote:
>>
>> > @@ -1887,7 +1930,8 @@ static int
>> >  get_source_info(struct dump_ctx *ctx,
>> >                  const struct tgsi_full_instruction *inst,
>> >                  struct source_info *sinfo,
>> > -                char srcs[3][255], char src_swizzle0[10])
>> > +                char srcs[3][255], char src_swizzle0[10],
>> > +                char fp64_srcs[3][255])
>>
>> Self-review: don't need to pass fp64_srcs in here, it can be local to
>> this.
>>
>> Dave.
>> _______________________________________________
>> virglrenderer-devel mailing list
>> virglrenderer-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel


More information about the virglrenderer-devel mailing list